feat(rust): WIP - fix decoding #687
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #687 +/- ##
==========================================
- Coverage 74.58% 69.28% -5.31%
==========================================
Files 66 12 -54
Lines 3286 1159 -2127
Branches 1461 1159 -302
==========================================
- Hits 2451 803 -1648
+ Misses 738 268 -470
+ Partials 97 88 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should not be merged in the current state, but it will help us fix all decoders because now it is possible to compare each subsequent commit to see the decoding results for each tile and how they have changed. Once we decode everything, we may rework the snapshots to be more consise, or remove them all together - but more importantly, we will remove the
DecodeErrorvariants from the Geometry, id, and property enums. As the result, any failed parse will result in CI error in the future.@Weixing-Zhang and @jjcfrancisco, please create decoding fixes against my snapshot-all branch - so as we merge stuff to it, it will show up here in this PR.